Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: adjust working directory in test.yml collect-info step #899

Conversation

uncleDecart
Copy link
Member

Following #898 we adjust collect-info working directory in new tests

@giggsoff
Copy link
Collaborator

giggsoff commented Oct 5, 2023

As I understood, ./eden hardcoded in collect-info to not fill it from the caller side. We still have ./eden as default. So do we really need the change?

@uncleDecart
Copy link
Member Author

@giggsoff there's a problem with missing archive in new workflows lf-edge/eve#3450 It might not be path, but has to be something

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giggsoff
Copy link
Collaborator

giggsoff commented Oct 5, 2023

@giggsoff there's a problem with missing archive in new workflows lf-edge/eve#3450 It might not be path, but has to be something

I still not sure that the problem is in path. Checked with added comment # created by collect-info action to eden.yml workflow and looks like I hit the same problem. May the problem be because of the comment?

@uncleDecart uncleDecart force-pushed the adjust-working-directory-in-collect-logs branch from 78e15d9 to 95ff153 Compare October 6, 2023 15:27
@uncleDecart
Copy link
Member Author

I see that in case of EdenGCP workflow we have it and seems like difference is only in using github.working directory and this comment. I removed the comment and hope it'll fix things . And being explicit on workflow directory won't worsen it IMHO :)

@giggsoff
Copy link
Collaborator

giggsoff commented Oct 6, 2023

Without explicit definition of working directory we use ./eden (assume it is different after your change, my previous fix you mentioned in the description was about changing the option) and as I can see in discussion it works, the action is able to find and run shell scripts to obtain required info. So why we should change the working directory if it works?

@uncleDecart
Copy link
Member Author

@giggsoff in this discussion there's a problem that new workflows don't include this archive, two things which are different is using working directory and having this comment. In new workflows which we are calling from eve we are downloading eden and explicitly specifying working directory. My reasoning changing it here is because that way it's explicit. I'm not sure still how GHA are functioning, especially in scenario, where you call them from another repository. If you want, we can remove working directory and clean up comment and try it all together and if it works it's good. If not -- I'd specify working directory and run again

@giggsoff
Copy link
Collaborator

giggsoff commented Oct 6, 2023

@giggsoff in this discussion there's a problem that new workflows don't include this archive, two things which are different is using working directory and having this comment. In new workflows which we are calling from eve we are downloading eden and explicitly specifying working directory. My reasoning changing it here is because that way it's explicit. I'm not sure still how GHA are functioning, especially in scenario, where you call them from another repository. If you want, we can remove working directory and clean up comment and try it all together and if it works it's good. If not -- I'd specify working directory and run again

Yes, please, remove only comment and keep options, it helps me in my attempt .

This hopefully fixes problem where publish logs cannot attach
archive

Signed-off-by: Pavel Abramov <[email protected]>
@uncleDecart uncleDecart force-pushed the adjust-working-directory-in-collect-logs branch from 95ff153 to 869d9ba Compare October 6, 2023 15:58
@uncleDecart
Copy link
Member Author

@giggsoff removed the comment and workflow directories remain the same

Copy link
Collaborator

@giggsoff giggsoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, let it try!

@giggsoff giggsoff merged commit 0af365a into lf-edge:master Oct 6, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants