-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions: adjust working directory in test.yml collect-info step #899
GitHub Actions: adjust working directory in test.yml collect-info step #899
Conversation
As I understood, |
@giggsoff there's a problem with missing archive in new workflows lf-edge/eve#3450 It might not be path, but has to be something |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I still not sure that the problem is in path. Checked with added comment |
78e15d9
to
95ff153
Compare
I see that in case of EdenGCP workflow we have it and seems like difference is only in using github.working directory and this comment. I removed the comment and hope it'll fix things . And being explicit on workflow directory won't worsen it IMHO :) |
Without explicit definition of working directory we use |
@giggsoff in this discussion there's a problem that new workflows don't include this archive, two things which are different is using working directory and having this comment. In new workflows which we are calling from eve we are downloading eden and explicitly specifying working directory. My reasoning changing it here is because that way it's explicit. I'm not sure still how GHA are functioning, especially in scenario, where you call them from another repository. If you want, we can remove working directory and clean up comment and try it all together and if it works it's good. If not -- I'd specify working directory and run again |
Yes, please, remove only comment and keep options, it helps me in my attempt . |
This hopefully fixes problem where publish logs cannot attach archive Signed-off-by: Pavel Abramov <[email protected]>
95ff153
to
869d9ba
Compare
@giggsoff removed the comment and workflow directories remain the same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, let it try!
Following #898 we adjust collect-info working directory in new tests